Rails 경로에서 이러한 제약 조건을 수행하는 더 좋은 방법이 있습니까?

Question

내 경로 파일의 절반 이상이 제약 조건 (및 해당 클래스)과 함께 처리되므로 더 좋은 방법이 있는지 궁금합니다. 다른 애완 동물을 추가하면 각각의 애완 동물은 동일하므로 파일이 매우 길어질 수 있습니다.

class AkcConstraint 
    TYPES = %w[sporting-group hound-group working-group terrier-group toy-group non-sporting-group herding-group misc-class] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:akc_group] 
    end 
end 

class AnkcConstraint 
    TYPES = %w[toy-group terrier-group gundog-group hound-group working-group utility-group non-sporting-group] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:ankc_group] 
    end 
end 

class CkcConstraint 
    TYPES = %w[sporting-group hound-group working-group terrier-group toy-group non-sporting-group herding-group] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:ckc_group] 
    end 
end 

class FciConstraint 
    TYPES = %w[group-1 group-2 group-3 group-4 group-5 group-6 group-7 group-8 group-9 group-10] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:fci_group] 
    end 
end 

class IkcConstraint 
    TYPES = %w[group-1 group-2 group-3 group-4 group-5 group-6 group-7 group-8 group-9 group-10] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:ikc_group] 
    end 
end 

class KcConstraint 
    TYPES = %w[hound-group working-group gundog-group terrier-group utility-group pastoral-group toy-group] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:kc_group] 
    end 
end 

class KusaConstraint 
    TYPES = %w[hound-group working-group gundog-group terrier-group utility-group pastoral-group toy-group] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:kusa_group] 
    end 
end 

class NzkcConstraint 
    TYPES = %w[toy-group terrier-group gundog-group hound-group working-group utility-group non-sporting-group] 
    def self.matches?(request) 
    TYPES.include? request.path_parameters[:nzkc_group] 
    end 
end 


# For dog groups and types 
match 'dogs/akc/:akc_group', :to => "dogs#index", :as => "akc_dogs", 
         :constraints => AkcConstraint 
match 'dogs/ankc/:ankc_group', :to => "dogs#index", :as => "ankc_dogs", 
         :constraints => AnkcConstraint 
match 'dogs/ckc/:ckc_group', :to => "dogs#index", :as => "ckc_dogs", 
         :constraints => CkcConstraint 
match 'dogs/fci/:fci_group', :to => "dogs#index", :as => "fci_dogs", 
         :constraints => FciConstraint 
match 'dogs/ikc/:ikc_group', :to => "dogs#index", :as => "ikc_dogs", 
         :constraints => IkcConstraint 
match 'dogs/kc/:kc_group', :to => "dogs#index", :as => "kc_dogs", 
         :constraints => KcConstraint 
match 'dogs/kusa/:kusa_group', :to => "dogs#index", :as => "kusa_dogs", 
         :constraints => KusaConstraint 
match 'dogs/nzkc/:nzkc_group', :to => "dogs#index", :as => "nzkc_dogs", 
         :constraints => NzkcConstraint 

나는 무엇보다 성능에 대해 우려하고 있습니다. 걱정해야합니까? 더 좋은 방법이 있습니까? 등 Akc, Ankc, Ckc 모든 가정

Answer 1

동일한 모델, 예컨대 상속 Club (나는 분명히 그들이 할 수 있기를 바란다), 그러면 당신은 분명히 이것을 더 간결하게, 적어도, 그리고 아마도 더 효율적으로 만들 수있다. 이런 식으로 뭔가 :

class ClubConstraint 
    Types = { # in actuality this should come from your database and not be 
      # hard-coded; otherwise it's going to be a big maintenance headache 
    :akc => %w[ sporting-group hound-group working-group 
       terrier-group toy-group  non-sporting-group 
       herding-group misc-class ], 
    # ... 
    :nzkc => %w[ toy-group  terrier-group gundog-group 
       hound-group  working-group utility-group 
       non-sporting-group ], 
    }.freeze 

    def matches? request 
    pparams = request.path_parameters 
    return unless club_groups = Types[ pparams[ :club ] ] 

    club_groups.include? pparams[ :group ] 
    end 
end 

# For dog groups and types 
match 'dogs/:club/:group', :to => "dogs#index", 
     :constraints => ClubConstraint.new 

이 내가 (당신의 :as => 옵션을 재 구현이 필요합니다)를 테스트하지 않았기 때문에 기록 된대로 작동하지 않을 수 있습니다,하지만 당신은 아이디어를 얻을.